Purpose
The primary goals for introducing preprocessor enhancements to Data Import are to provide support for a wider range of file import use cases and improve the experience of working with Powershell scripts within Data Import.
Specifically:
- Provide support for non-CSV files (e.g. tab-delimited, fixed-width, or XML)
- Enable reshaping of the row grain of the file (one row becomes multiple or vice-versa)
- Enable exclusion of rows (e.g. student assessment rows that indicate the student was not tested)
- Enable invocation of the ODS API from preprocessor scripts (dynamically selecting the API used by the executing agent)
- Improve the management and sharing capabilities of PowerShell scripts used by preprocessors
- Maintain scripts in the database instead of the file system and provide a UI for managing
- Include script dependencies in template sharing and import/export templates
Related epic: - EDFI-411Getting issue details... STATUS
Preprocessing Capabilities in Data Import
Data Import already supports two PowerShell integration capabilities for preprocessing of files:
- Custom Record Processing
- Provided via an optional selection of a Row Processor (PS1 file) on the agent screen.
- This feature enables scripting of modifications to field values within a row.
- More information
- Custom File Generation
- Provided via a "File System / PowerShell" agent type choice on the agent screen, which enables the selection of a Generator (PS1 file).
- This feature enables the scripting of file generation on a predefined schedule.
- More information
With the proposed enhancements, a third preprocessing capability will be supported:
- Custom File Processing
- Provided via an optional selection of a File Processor (PS1 file) on the map screen.
- This feature integrates the source file into the PowerShell pipeline to support a wide variety of transformations resulting in a tabular output compatible with the existing mapping designer.
Understanding Custom File Processing
The PowerShell script implementation of Custom File Processing works a little differently than the existing Custom Row Processing.
How It Works: Custom Row Processing
The existing Custom Row Processing operates against the agent.
Set the following at the top of the file:
param ($row)
The parameter name must be called $row
.
Properties of the parameter variable exist for each column. Properties can be read, updated, or new ones created. Examples:
$row.'sasid' = $row.'sasid'.Trim()
$row.'newfield' = $row.'sasid' + '!'
How It Works: Custom File Processing
By contrast, Custom File Processing uses pipeline input via an Advanced Function, and it operates against the data map rather than the agent.
Set the following at the top of the file:
[CmdletBinding()]
Param(
[Parameter(Mandatory = $true, ValueFromPipeline = $true)][string[]]$file
)
Alternatively, substitute the array of arrays parameter with a flat array parameter if you want your pipeline processing to be executed per row instead of for the whole file:
[Parameter(Mandatory = $true, ValueFromPipeline = $true)][string]$line
The PowerShell advanced function uses input process methods, represented by the Begin
, Process
, and End
blocks of the function, to process the stream as it passes through the PowerShell pipeline.
Custom File Processing Examples
This example demonstrates processing the entire file at once. The Begin and End blocks are optional. They're included here for illustration.
[CmdletBinding()] Param( [Parameter(Mandatory = $true, ValueFromPipeline = $true)][string[]]$file ) Begin { Write-Information "Converting tabs to commas" } Process { Write-Output $file.Replace("`t", ",") } End { Write-Information "Finished converting tabs to commas" }
This example demonstrates processing each line individually.
[CmdletBinding()] Param( [Parameter(Mandatory = $true, ValueFromPipeline = $true)]string[]$line ) Begin { $fieldDefinitions = @( [PSCustomObject]@{ "Name" = "SCHOOL_ID"; "Start" = 0; "Length" = 10; } [PSCustomObject]@{ "Name" = "STUDENT_ID"; "Start" = 10; "Length" = 10; } [PSCustomObject]@{ "Name" = "FIRST_NAME"; "Start" = 20; "Length" = 12; } [PSCustomObject]@{ "Name" = "LAST_NAME"; "Start" = 32; "Length" = 12; } [PSCustomObject]@{ "Name" = "GENDER"; "Start" = 44; "Length" = 6; } ) Write-Output (($fieldDefinitions | %{ $_.Name }) -join ",") } Process { $builder = [System.Text.StringBuilder]::new() $fieldDefinitions | %{ $field = $line.Substring($_.Start, $_.Length) $needsQuotes = ($Field -match ",") $isLast = ($_.Start + $_.Length -ge $line.Length) if ($needsQuotes) { $builder.Append("`"") | Out-Null } $builder.Append($field.Trim()) | Out-Null if ($needsQuotes) { $builder.Append("`"") | Out-Null } if (!$IsLast) { $builder.Append(",") | Out-Null } } Write-Output $builder.ToString() }
Understanding ODS API Invocation
In the context of preprocessing a file, it can be useful to read data from the ODS via the API. This is supported by exposing the agent connection details at run-time via the following PowerShell variables:
$ODS.BaseUrl
- The URL for the ODS API (including the path, e.g. /data/v3[/year])$ODS.AccessToken
- A valid bearer token to authorize access to the ODS API
This partial example demonstrates building an associated array of students for later lookups.
Write-Information "Preparing to load student data..." $runStatus.ScriptStartTime = Get-Date $runStatus.StudentLoadStartTime = Get-Date $studentIds = @{} try { $continue = $true $offset = 0 $limit = 100 while ($continue) { $response = Invoke-WebRequest -URI "$($ODS.BaseUrl)/students?limit=$limit&offset=$offset" -Headers @{"Authorization"="Bearer $($ODS.AccessToken)"} -UseBasicParsing if ($response.StatusCode -ne 200) { Write-Error "Error invoking the EdFi API: $_"; return } $students = ConvertFrom-Json $response if ($students.Length -gt 0) { foreach ($student in $students) { $districtId = "NOT SET" $stateId = "NOT SET" foreach ($idCode in $student.identificationCodes) { if ($idCode.studentIdentificationSystemDescriptor -eq "District") { $districtId = $idCode.identificationCode } if ($idCode.studentIdentificationSystemDescriptor -eq "State") { $stateId = $idCode.identificationCode } } $studentIds.Add($stateId, $districtId) } } else { $continue = $false } $offset += $limit } } catch { Write-Error "Error loading list of Student State/District IDs from the ODS: $($_.Exception.Message)" return }
Understanding the Big Picture
Design Considerations
Do we need both Custom Record Processing and Custom File Processing? NEED INPUT (working assumption is that we retain)
There is an overlap between the capabilities of the existing Custom Record Processing and the new Custom File Processing feature:
- Both can modify values at the row level.
- Custom File Processing additionally supports adding new fields to the row as well as the processing of the entire file for more complex scenarios.
Since Custom File Processing provides a superset of functionality, there is a consideration to remove (or at least deprecate) the existing Custom Record Processing feature:
- Benefits of removing:
- Strategically, if two file preprocessing methods are not needed, then we should progress to that end state.
- Avoid additional work to improve refactor Custom Record Processing to support improved preprocessing management and sharing capabilities planned for Customer File Processing.
- However, we will need to identify a migration strategy for customers currently using Custom Record Processing.
- Benefits of retaining:
- If there are use cases for agent-specific processing.
- Opportunity to incorporate invocation of ODS /API from agent preprocessor (rather than data map preprocessor), which naturally aligns with the concrete API server connection.
Does Custom File Generation need to be considered this design?
Custom File Generation uses a PowerShell script in an entirely different context than Customer Record Processing and Custom File Processing. Whereas the latter items modify the content of an uploaded file during processing, Custom File Generation executes a script on a schedule to generate a file.
As a result, Custom File Generation is not impacted by the proposed preprocessor enhancements.
However, there is value in consistently managing all PowerShell scripts. Currently, these scripts are discovered and used from known paths in the file system. The proposed enhancements include migrating script storage to the database and provide a UI for managing the scripts. It is likely beneficial if these enhancements are applied to Custom File Generation as well.
Where will ODS API invocation support be implemented? NEED INPUT (working assumption is that we support both)
There are three possibilities:
- API invocation is supported by Custom Record Processing (on Agent screen)
- This works well if we are confident that any logic requiring use of the API happens after the file has been converted to tabular data by the Custom File Processor.
- However, it is of course only applicable if we retain the Custom Record Processing capability.
- API invocation is supported by Custom File Processing (on Data Map screen)
- Building a Data Map requires discovery of the source file columns. When a Custom File Processor is used and that script requires the use of the API, then we must prompt for an API Connection for executing the script (per Multi-Connection enhancements).
- If we use this approach, it may be preferred that ODS API support for the preprocessor is explicitly enabled as a configuration option for each applicable Preprocessor script.
- API invocation is supported by Custom Record Processing and Custom File Processing
- This favors flexibility for undiscovered use cases.
Security concerns? NEED INPUT
Providing the capability for an application to dynamically execute user-provided PowerShell scripts adds a potentially significant attack vector to the web app and transform load console app.
While Data Import already supports the execution of PowerShell scripts, those scripts are read from the file system. With these enhancements, scripts can be managed via the UI.
We need to put some thoughts into ensuring effective security measures are considered, whether this is constraints on script capabilities or documenting risks and recommendations for restricting access to the server. We can also consider an option to disable the use of scripts.
User Interface Changes
Menu
Manage Preprocessors
Add Preprocessor
800
Add Data Map
Export Template
- Custom File Processor script associated with selected Data Maps should be automatically included (similar to Lookups).
- If Custom Row Processors exist, an additional step in the wizard will be shown after selecting Data Maps called to provide an optional selection of Custom Row Processors.
- Custom File Generators are not supported in templates.
- No UI changes are required for importing templates.
Database Changes (TODO)
Table | Change | Justification |
---|---|---|
Preprocessors | New Table:
| Supports storage of PowerShell scripts. EF Core note: Implement PreprocessorType as an enum. |
DataMaps | New column:
| Optionally associate a data map with a Custom File Processor. |
Agents | Removed columns:
New columns:
| Replace Custom Row Processor and Custom File Generator filenames with database references. This will require a specialized migration:
|
Questions:
- Should we name the new table "Scripts" instead of "Preprocessors"? Role-specific foreign key column names could more naturally be called "FileProcessorScriptId" versus "FileProcessorPreprocessorId" (notice that I opted to drop "Preprocessor" entirely in the changes described above).